Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce TGeoDetectorElementSplitter & splitted detector element constructors #873

Merged

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented Jul 12, 2021

This PR introduces a new interface in the TGeo plugin that allows splitting of TGeoDetectorElement objects and adds a necessary constructor for this to the TGeoDetectorElement.

This will be needed for the ALICE o2 studies (generic splitter from disk to trapezoids), but also for the TGeo version of the ATLAS ITk, where dedicated splitters need to be written.

Tagging some interested parties: @paulgessinger @niermann999 @noemina

The splitting has to be activated with a switch:

--geo-tgeo-cyl-disc-split

And then, consequently, all volumes need to define how they wanna perform the splitting, e.g. for no splitting:

--geo-tgeo-cyl-nz-segs -1
--geo-tgeo-cyl-nphi-segs -1
--geo-tgeo-disc-nr-segs -1
--geo-tgeo-disc-nphi-segs -1

versus splitting:

--geo-tgeo-cyl-nz-segs 6
--geo-tgeo-cyl-nphi-segs 32
--geo-tgeo-disc-nr-segs 6
--geo-tgeo-disc-nphi-segs 32

@asalzburger asalzburger added Feature Development to integrate a new feature 🚧 WIP Work-in-progress Component - Plugins Affects one or more Plugins labels Jul 12, 2021
@asalzburger asalzburger added this to the next milestone Jul 12, 2021
@asalzburger asalzburger self-assigned this Jul 12, 2021
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #873 (8fee3f1) into main (6e94ec0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #873   +/-   ##
=======================================
  Coverage   48.66%   48.66%           
=======================================
  Files         331      331           
  Lines       17129    17129           
  Branches     8094     8094           
=======================================
  Hits         8336     8336           
  Misses       3087     3087           
  Partials     5706     5706           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e94ec0...8fee3f1. Read the comment docs.

@asalzburger
Copy link
Contributor Author

Splitting for DiscSurface layers is done:

Screenshot 2021-07-12 at 16 43 47

This is an example of 6 radial splits and 32 phi segments.

@asalzburger
Copy link
Contributor Author

Screenshot 2021-07-15 at 13 52 18

Splitting for Cylinders enabled.

@asalzburger asalzburger force-pushed the feat-tgeo-split-disc-into-trapezoids branch from 6c6f27f to 191781c Compare July 15, 2021 11:58
@asalzburger asalzburger removed the 🚧 WIP Work-in-progress label Jul 15, 2021
@asalzburger asalzburger force-pushed the feat-tgeo-split-disc-into-trapezoids branch from 5cb7bfc to 3170ca2 Compare July 15, 2021 20:21
@asalzburger asalzburger merged commit b14a419 into acts-project:main Jul 16, 2021
@asalzburger asalzburger deleted the feat-tgeo-split-disc-into-trapezoids branch July 16, 2021 13:21
@paulgessinger paulgessinger modified the milestones: next, v10.0.0 Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Plugins Affects one or more Plugins Feature Development to integrate a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants