-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce TGeoDetectorElementSplitter & splitted detector element constructors #873
Merged
asalzburger
merged 12 commits into
acts-project:main
from
asalzburger:feat-tgeo-split-disc-into-trapezoids
Jul 16, 2021
Merged
feat: introduce TGeoDetectorElementSplitter & splitted detector element constructors #873
asalzburger
merged 12 commits into
acts-project:main
from
asalzburger:feat-tgeo-split-disc-into-trapezoids
Jul 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalzburger
added
Feature
Development to integrate a new feature
🚧 WIP
Work-in-progress
Component - Plugins
Affects one or more Plugins
labels
Jul 12, 2021
Codecov Report
@@ Coverage Diff @@
## main #873 +/- ##
=======================================
Coverage 48.66% 48.66%
=======================================
Files 331 331
Lines 17129 17129
Branches 8094 8094
=======================================
Hits 8336 8336
Misses 3087 3087
Partials 5706 5706 Continue to review full report at Codecov.
|
asalzburger
force-pushed
the
feat-tgeo-split-disc-into-trapezoids
branch
from
July 15, 2021 11:58
6c6f27f
to
191781c
Compare
niermann999
reviewed
Jul 15, 2021
asalzburger
force-pushed
the
feat-tgeo-split-disc-into-trapezoids
branch
from
July 15, 2021 20:21
5cb7bfc
to
3170ca2
Compare
niermann999
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new interface in the
TGeo
plugin that allows splitting ofTGeoDetectorElement
objects and adds a necessary constructor for this to theTGeoDetectorElement
.This will be needed for the ALICE o2 studies (generic splitter from disk to trapezoids), but also for the TGeo version of the ATLAS ITk, where dedicated splitters need to be written.
Tagging some interested parties: @paulgessinger @niermann999 @noemina
The splitting has to be activated with a switch:
And then, consequently, all volumes need to define how they wanna perform the splitting, e.g. for no splitting:
versus splitting: