Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Boost warnings due to deprecations #880

Merged
merged 3 commits into from
Jul 21, 2021

Conversation

paulgessinger
Copy link
Member

Had to reopen from #665, because the target branch had changed.

Let's see what this looks like now.

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #880 (ec7d6e1) into main (b14a419) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #880   +/-   ##
=======================================
  Coverage   48.66%   48.66%           
=======================================
  Files         331      331           
  Lines       17129    17129           
  Branches     8094     8094           
=======================================
  Hits         8336     8336           
  Misses       3087     3087           
  Partials     5706     5706           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b14a419...ec7d6e1. Read the comment docs.

@paulgessinger
Copy link
Member Author

paulgessinger commented Jul 19, 2021

The deprecation warning starts in 1.71.0, but there is no direct replacement until 1.72.0. Since this is entirely confined to a single compilation unit, I added a check and up until and including 1.71.0 we'll use the old deprecated header, and starting from 1.72.0 we use the replacement. This means for 1.71.0 the deprecation warning stays visible.

Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@asalzburger asalzburger merged commit 4340ad2 into acts-project:main Jul 21, 2021
@paulgessinger paulgessinger modified the milestones: next, v10.0.0 Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants