feat: Introduce json configuration for tgeo #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #884 +/- ##
=======================================
Coverage 48.73% 48.73%
=======================================
Files 337 337
Lines 17281 17281
Branches 8162 8162
=======================================
Hits 8422 8422
Misses 3118 3118
Partials 5741 5741 Continue to review full report at Codecov.
|
|
Hi @niermann999 - this is still marked as draft & fails in the build - I think that was the one you wanted to bring in first? |
niermann999
force-pushed
the
feat-tgeo-jsonconfig
branch
from
cb0d295
to
eb96701
Compare
…roject#884) The options handling of the TGeoDetector is moved from boost to json based configuration. It builds upon the recent reordering of the detector options in acts-project#923. New functionality is introduces in Examples/Io/Json. Since it needs information from the TGeo plugin, the latter is only linked in the example io when the plugin is required.
niermann999
force-pushed
the
feat-tgeo-jsonconfig
branch
from
3c765b8
to
f8c74d9
Compare
asalzburger
approved these changes
Sep 16, 2021
niermann999
added a commit
to niermann999/acts
that referenced
this pull request
Sep 21, 2021
The new ITk strip module splitter is based on the recent introduction of a json configuration for the TGeoDetector (acts-project#884). It reads in a json configuration file to which a mapping has been added now, that contains the splitting parameters by sensor name. Barrel modules are split in two or four DetectorElements, depending on the layer, while the endcap modules are split according to custom r boundaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using boost options, this PR introduces a json based configuration for the TGeo detector. The json config is included in Examples/Io for now and provides read functionality for the beampipe and the TGeoLayerBuilder