Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build passive layers for DD4hep #892

Merged

Conversation

asalzburger
Copy link
Contributor

This PR fixes an issue that only the beam pipe was regarded as a passive layer to be built, an issue easily spotted in the OpenDataDetector setup.

With this one-line fix, suddenly the Solenoid and the Pixel Support Tube show up.

12:21:38    DD4hepConver   INFO      Translating DD4hep geometry into Acts geometry
12:21:38    DD4hepConver   INFO      Translating DD4hep sub detector: BeamPipe
12:21:38    DD4hepConver   INFO      Translating DD4hep sub detector: Pixels
12:21:38    DD4hepConver   INFO      Translating DD4hep sub detector: PST
12:21:38    DD4hepConver   INFO      Translating DD4hep sub detector: ShortStrips
12:21:38    DD4hepConver   INFO      Translating DD4hep sub detector: LongStrips

@asalzburger asalzburger added Bug Something isn't working Component - Examples Affects the Examples module labels Jul 20, 2021
@asalzburger asalzburger added this to the next milestone Jul 20, 2021
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #892 (045bff4) into main (99df92e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #892   +/-   ##
=======================================
  Coverage   48.66%   48.66%           
=======================================
  Files         331      331           
  Lines       17129    17129           
  Branches     8094     8094           
=======================================
  Hits         8336     8336           
  Misses       3087     3087           
  Partials     5706     5706           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99df92e...045bff4. Read the comment docs.

@asalzburger asalzburger merged commit d7adb00 into acts-project:main Jul 20, 2021
@asalzburger asalzburger deleted the fix-dd4hep-build-passive-layers branch July 20, 2021 12:20
@paulgessinger paulgessinger modified the milestones: next, v10.0.0 Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants