-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update OpenDataDetector, refine DD4hep material handling #895
Merged
asalzburger
merged 10 commits into
acts-project:main
from
asalzburger:feat-dd4hep-boundary-material-4-passive-layers
Jul 26, 2021
Merged
feat: update OpenDataDetector, refine DD4hep material handling #895
asalzburger
merged 10 commits into
acts-project:main
from
asalzburger:feat-dd4hep-boundary-material-4-passive-layers
Jul 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalzburger
added
Component - Examples
Affects the Examples module
Feature
Development to integrate a new feature
Component - Plugins
Affects one or more Plugins
labels
Jul 22, 2021
Codecov Report
@@ Coverage Diff @@
## main #895 +/- ##
=======================================
Coverage 48.66% 48.66%
=======================================
Files 331 331
Lines 17129 17129
Branches 8094 8094
=======================================
Hits 8336 8336
Misses 3087 3087
Partials 5706 5706 Continue to review full report at Codecov.
|
niermann999
reviewed
Jul 23, 2021
…ub.com:asalzburger/acts into feat-dd4hep-boundary-material-4-passive-layers
niermann999
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Examples
Affects the Examples module
Component - Plugins
Affects one or more Plugins
Feature
Development to integrate a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines two features that are coupled:
With this, quite remarkable agreement between G4 and ACTS in terms of material budget can be achieved.
The changes to the OpenDataDetector include: