Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update OpenDataDetector, refine DD4hep material handling #895

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented Jul 22, 2021

This PR combines two features that are coupled:

  • updates the OpenDataDetector description (with boundary material)
  • refines the way boundary material is handled (e.g. ODDCylinderLayerBuilder)

With this, quite remarkable agreement between G4 and ACTS in terms of material budget can be achieved.

Screenshot 2021-07-22 at 10 27 41

The changes to the OpenDataDetector include:

  • allow boundary material for solenoid volume
  • reduce thickness of solenoid coil to match ~ATLAS values

@asalzburger asalzburger added Component - Examples Affects the Examples module Feature Development to integrate a new feature Component - Plugins Affects one or more Plugins labels Jul 22, 2021
@asalzburger asalzburger added this to the next milestone Jul 22, 2021
@asalzburger asalzburger self-assigned this Jul 22, 2021
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #895 (9e2c3b3) into main (bb4ba16) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #895   +/-   ##
=======================================
  Coverage   48.66%   48.66%           
=======================================
  Files         331      331           
  Lines       17129    17129           
  Branches     8094     8094           
=======================================
  Hits         8336     8336           
  Misses       3087     3087           
  Partials     5706     5706           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb4ba16...9e2c3b3. Read the comment docs.

@asalzburger asalzburger merged commit 0e83c06 into acts-project:main Jul 26, 2021
@paulgessinger paulgessinger modified the milestones: next, v10.0.0 Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Feature Development to integrate a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants