fix: Json Surface Writing #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corentin-Allaire
added
Bug
Codecov Report
@@ Coverage Diff @@
## main #897 +/- ##
=======================================
Coverage 48.66% 48.66%
=======================================
Files 331 331
Lines 17129 17129
Branches 8094 8094
=======================================
Hits 8336 8336
Misses 3087 3087
Partials 5706 5706 Continue to review full report at Codecov.
|
paulgessinger
approved these changes
Jul 26, 2021
|
I think this is it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue in the json surface writing where we used a pointer on a surface instead of a shared pointer. This resolves issue #883 .