-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: computation of shared measurement in CKF #898
feat: computation of shared measurement in CKF #898
Conversation
Adding shared hits to performance macros
Here is the shared hits distribution if we recompute that quantity taking into account the truth particle information (i.e. measurements used only by reconstructed tracks from the same truth particle are not labelled as shared): nSharedHits_recomputed.pdf |
Codecov Report
@@ Coverage Diff @@
## main #898 +/- ##
=======================================
Coverage 48.48% 48.48%
=======================================
Files 334 334
Lines 17091 17091
Branches 8081 8081
=======================================
Hits 8287 8287
Misses 3099 3099
Partials 5705 5705
Continue to review full report at Codecov.
|
Is this WIP or ready to review? |
Hi @paulgessinger , I think this PR is ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @CarloVarni , I have some further comments, which should be easy to address. I will approve once they are addressed.
Moving computation
computation of shared hits in ad-hoc method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @CarloVarni , thank you for the changes. It looks good to me.
Examples/Algorithms/TrackFinding/include/ActsExamples/TrackFinding/TrackFindingAlgorithm.hpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/TrackFinding/include/ActsExamples/TrackFinding/TrackFindingAlgorithm.hpp
Outdated
Show resolved
Hide resolved
Updating this ... |
I think we'll have to wait for one more round of CI before merging. |
Computation of shared measurements in CKF. After track reconstruction, the code runs on all reconstructed tracks and takes into account the measurements used in each track by accessing the measurement index contained in the source link. If the same measurement is used by more than one track, it is flagged as a SharedHit.
The measurement will have both the Measurement and the Shared flag, so no change in measurement-related variables is expected.
In attachment the number of Shared Measurement distribution as a function of eta and pt.
shared_vs_eta.pdf
shared_vs_pt.pdf
Here is also the number of shared hits for tracks: nSharedHits_raw.pdf
Concerning the color legend:
the labelling is taken from CsvMultiTrajectoryWriter.cpp
The high number of shared measurements is a result of the CKF reconstructing several tracks from the same truth particles. These reconstructed tracks shared almost all the measurements.
For instance this particular case in which three different tracks are reconstructed
recoParticlesFor_78019200.pdf:
Pinging @XiaocongAi @paulgessinger @asalzburger