refactor: Define interface for generators #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
Codecov Report
@@ Coverage Diff @@
## main #919 +/- ##
=======================================
Coverage 48.46% 48.46%
=======================================
Files 334 334
Lines 17067 17067
Branches 8074 8074
=======================================
Hits 8271 8271
Misses 3094 3094
Partials 5702 5702 Continue to review full report at Codecov.
|
XiaocongAi
reviewed
Aug 5, 2021
Examples/Algorithms/Generators/ActsExamples/Generators/EventGenerator.hpp
Show resolved
Hide resolved
XiaocongAi
approved these changes
Aug 6, 2021
This is driven by the python binding implementation. std::function has the downside of making pybind11 do a round trip through python. This interface is equivalent, but slightly more complex. I think it's still acceptable.
This reverts commit be060ab.
paulgessinger
force-pushed
the
py/gen_if
branch
from
d838216
to
b877ab0
Compare
|
@XiaocongAi can you reapprove? |
XiaocongAi
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is driven by the python binding implementation. std::function has
the downside of making pybind11 do a round trip through python. This
interface is equivalent, but slightly more complex. I think it's still
acceptable.