refactor: Make the DigitizationConfigurator usable #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously only privately used in the DigitizationConfigExample, but can be useful in other context. At the same time, this introduces a constructor for `DigitizationConfig` that only takes a finished geometry hierachy map (and no program options), which can for instance be built with the configurator.
15 tasks
Codecov Report
@@ Coverage Diff @@
## main #921 +/- ##
=======================================
Coverage 48.63% 48.63%
=======================================
Files 334 334
Lines 17149 17149
Branches 8086 8086
=======================================
Hits 8340 8340
Misses 3091 3091
Partials 5718 5718 Continue to review full report at Codecov.
|
|
Looks good to me! Some of the CI jobs seem to be failing but for spurious reasons, anyways we'll see how they do once the branch is rebased. |
gagnonlg
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously only privately used in the
DigitizationConfigExample, but can be useful in other context.
At the same time, this introduces a constructor for
DigitizationConfigthat only takes a finished geometry hierachy map (and no program options), which can for instance
be built with the configurator.