refactor: Fitting and Finding algorithm function interface #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes both the fitting and the finding algorithm to use a regular interface with virtual methods rather than std::function to decouple the actual fitter/finder instances. The decoupling is only for compile-time memory usage reduction. The reason is that pybind11 does a round trip throught python with std::function, which we want to avoid. This is functionally equivalent, but uses a different mechanism. Also adds factory functions for these decoupled objects. We don't foresee these to be switchable, this decoupling is done for purely technical reasons anyway.
15 tasks
Codecov Report
@@ Coverage Diff @@
## main #922 +/- ##
=======================================
Coverage 48.66% 48.66%
=======================================
Files 331 331
Lines 17129 17129
Branches 8094 8094
=======================================
Hits 8336 8336
Misses 3087 3087
Partials 5706 5706 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes both the fitting and the finding algorithm to use a regular
interface with virtual methods rather than std::function to decouple the
actual fitter/finder instances. The decoupling is only for compile-time
memory usage reduction. The reason is that pybind11 does a round trip
throught python with std::function, which we want to avoid. This is
functionally equivalent, but uses a different mechanism.
Also adds factory functions for these decoupled objects. We don't
foresee these to be switchable, this decoupling is done for purely
technical reasons anyway.