refactor: Make Detectors constructible without boost po #923
Conversation
Adds an overload to the detector's `finalize()` which accepts a newly added `Config` object. The previous overload that takes boost program options constructs such a `Config` object and forwards to the other overload. This allows construction of the detector directly, with out program options. Additionally, the defaults for configuration values are harmonized, the canonical source is now the `Config` objects, but I tried to have the po versions consistents. Currently this only ports - `AlignedDetector` - `GenericDetector` - `DD4hepDetector` I think `TGeoDetector` should definitely be added. @asalzburger do you think I missed anything?
Codecov Report
@@ Coverage Diff @@
## main #923 +/- ##
=======================================
Coverage 48.63% 48.63%
=======================================
Files 334 334
Lines 17149 17149
Branches 8086 8086
=======================================
Hits 8340 8340
Misses 3091 3091
Partials 5718 5718 Continue to review full report at Codecov.
|
|
Hi @paulgessinger - |
|
I'll add the TGeo detector tomorrow. |
|
I will add the TGeoDetector. |
|
Ok. I briefly checked with help from @niermann999 that the ITk TGeo input seems to produce the same number of layers as was the case before the change, and from checking a few obj files and test propagation, the geometry seems to be ok.
|
|
@asalzburger could you have another look and potentially reapprove? |
…roject#884) The options handling of the TGeoDetector is moved from boost to json based configuration. It builds upon the recent reordering of the detector options in acts-project#923. New functionality is introduces in Examples/Io/Json. Since it needs information from the TGeo plugin, the latter is only linked in the example io when the plugin is required.
* Basic json config for tgeodetector and cylinder/disk splitter (#884) The options handling of the TGeoDetector is moved from boost to json based configuration. It builds upon the recent reordering of the detector options in #923. New functionality is introduces in Examples/Io/Json. Since it needs information from the TGeo plugin, the latter is only linked in the example io when the plugin is required.
Adds an overload to the detector's
finalize()which accepts a newlyadded
Configobject. The previous overload that takes boost programoptions constructs such a
Configobject and forwards to the otheroverload. This allows construction of the detector directly, with out
program options.
Additionally, the defaults for configuration values are harmonized, the
canonical source is now the
Configobjects, but I tried to have the poversions consistents.
Currently this only ports
AlignedDetectorGenericDetectorDD4hepDetectorI think
TGeoDetectorshould definitely be added.@asalzburger do you think I anything else is important?