Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Always create bound states in (C)KF #936

Merged
merged 3 commits into from
Aug 12, 2021

Conversation

XiaocongAi
Copy link
Contributor

In the current (C)KF, a curvilinear state is created if the track reaches the passive material surface. This was initially implemented due to the reason that a bound state on a Cylinder surface is not working properly. However, this seems to be not the case any more. Hence, bound states are alwasy created, which should be more accurate.

@XiaocongAi XiaocongAi added the Improvement Changes to an existing feature label Aug 9, 2021
@XiaocongAi XiaocongAi added this to the next milestone Aug 9, 2021
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #936 (4636875) into main (360b29d) will increase coverage by 0.08%.
The diff coverage is 5.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
+ Coverage   48.66%   48.75%   +0.08%     
==========================================
  Files         331      331              
  Lines       17131    17101      -30     
  Branches     8092     8070      -22     
==========================================
  Hits         8337     8337              
+ Misses       3087     3057      -30     
  Partials     5707     5707              
Impacted Files Coverage Δ
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 30.16% <0.00%> (+1.67%) ⬆️
Core/include/Acts/TrackFitting/KalmanFitter.hpp 38.06% <9.09%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 360b29d...4636875. Read the comment docs.

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine and makes sense to change if the problem on cylinder surfaces is gone.

@asalzburger asalzburger merged commit cb728a4 into acts-project:main Aug 12, 2021
@paulgessinger paulgessinger modified the milestones: next, v12.0.0 Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants