refactor!: Seeding config simplification #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlangenberg
approved these changes
Aug 16, 2021
Codecov Report
@@ Coverage Diff @@
## main #945 +/- ##
=======================================
Coverage 48.63% 48.63%
=======================================
Files 334 334
Lines 17149 17149
Branches 8086 8086
=======================================
Hits 8340 8340
Misses 3091 3091
Partials 5718 5718
Continue to review full report at Codecov.
|
paulgessinger
force-pushed
the
seeding-config-rework
branch
from
58e58ec
to
891b8fd
Compare
|
I will update the branch & then follow up later. |
|
This was approved by @robertlangenberg - merging. |
|
@paulgessinger - can you resolve the conflict now please after #941 went in? |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dedicated config struct in
SeedingAlgorithmin favor of it containing three config structs for the grid, seed finder and seed filter. Users of the seeding algorithm need to make sure that these config structs are configured consistently.SeedingAlgorithm's constructor runs a number of checks to see if the config seems to make sense.I tested the seeding example with this, and it gives the same number of seeds for a few particle gun events as main.
This is rebased on top of #941, so should be reviewed/merged after that.