-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use material before the first measurement in smoothing #956
fix: Use material before the first measurement in smoothing #956
Conversation
Codecov Report
@@ Coverage Diff @@
## main #956 +/- ##
==========================================
- Coverage 48.47% 48.46% -0.02%
==========================================
Files 334 334
Lines 17059 17067 +8
Branches 8069 8074 +5
==========================================
+ Hits 8270 8271 +1
- Misses 3088 3094 +6
- Partials 5701 5702 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, but let's wait for @XiaocongAi's review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Corentin-Allaire , thank you for the PR. I have only one comment.
In the CKF, shall we do the following:?
- If we are going to run smoothing to get the fitted track parameters, we do the same as in KF, i.e. we create only material state before the first measuement and create measurement/hole/material after the first measurement;
- If we are don't care about the track fitting, i.e. the CKF is used just for track finding, we only create measurement/hole state after the first measurement.
Only create pre-measurement material state in fitting mode Co-authored-by: Xiaocong Ai <xiaocong.ai@cern.ch>
I think this is a great idea, I merged your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok this seems fine now. Let's merge it.
This PR allow material situated before the first measurement (eg : beampipe) to be properly accounted for in the KF and CKF. This will fix issue #906