Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add pybind11 as a thirdparty component #964

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

paulgessinger
Copy link
Member

This is in preparation for the python bindings #845.

When this is merged, #845 will have reduced changes.

This is in preparation for the python bindings
@paulgessinger paulgessinger added this to the next milestone Aug 27, 2021
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, that is a copy into third party, right?

@paulgessinger
Copy link
Member Author

Yes

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #964 (021f317) into main (b87b53c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #964   +/-   ##
=======================================
  Coverage   48.46%   48.46%           
=======================================
  Files         334      334           
  Lines       17067    17067           
  Branches     8074     8074           
=======================================
  Hits         8271     8271           
  Misses       3094     3094           
  Partials     5702     5702           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87b53c...021f317. Read the comment docs.

@paulgessinger paulgessinger merged commit 30ebed9 into acts-project:main Aug 30, 2021
@paulgessinger paulgessinger deleted the add-pybind11 branch August 30, 2021 07:12
@paulgessinger paulgessinger modified the milestones: next, v12.0.1 Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants