refactor: Context in bin adjustment and trapezoid surface bin adjustment #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corentin-Allaire
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #966 +/- ##
==========================================
+ Coverage 48.46% 48.48% +0.02%
==========================================
Files 334 334
Lines 17067 17091 +24
Branches 8074 8081 +7
==========================================
+ Hits 8271 8287 +16
- Misses 3094 3099 +5
- Partials 5702 5705 +3
Continue to review full report at Codecov.
|
Corentin-Allaire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bin adjustment for surface used the default constructor of the geometry context to get the surface transform. This doesn't work for all context so it now uses the geometry context as an input.
This also add bin adjustment for trapezoid bound (and the relevant test).