-
-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maintenance] TypeScript migration #1483
Comments
While looking at this, I found a cool package (https://github.com/codemix/deprank) that uses PageRank algorithm to find the 'most important' files in the project and list out dependencies. This can give a good idea of which files are good to tackle first for JS -> TS conversion (and which files may be more challenging). Here's the command I ran for |
One thought I had on this (may have been discussed previously). For truly strict typing, the function components themselves should be typed as Edit: Decided to look into this and seems latest consensus is that it's not needed. Will stick with the |
@MatissJanis I think we should pin this so that community is aware that the project is still accepting typescript PRs. |
That makes sense @joel-jeremy , but we can only pin 3x issues. Perhaps lets wait for one of the experimental features to be released and then pin this one? |
We are currently at around 50% TypeScript. There is still lots of work to be done to get to 100%.
Feel free to help out by converting a file here and there. Also hardening the existing TS files is welcome (i.e. converting
unknown
andany
to more strict types).Please do not send massive migration PRs. Try to keep it small and isolated.
The text was updated successfully, but these errors were encountered: