Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐ [Documentation] - instruct the user to cd into directory with fly.toml #140

Closed
Jackenmen opened this issue Mar 26, 2023 · 2 comments
Closed
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Jackenmen
Copy link
Contributor

Description

The Deploying Actual on fly.io with a container image document should clearly instruct the user that when running fly launch command (and commands after that), they need to be running them in the directory with fly.toml file that they created earlier.

For comparison, the Deploying Actual section of Deploying Actual on fly.io with git document actually does a lot better job of this by clearly showing how to navigate each step of the deployment process. I think it has a bit too many of too big screenshots but nonetheless, it makes it hard to do something wrong.

Documentation URL

https://github.com/actualbudget/docs/blob/master/docs/Installing/fly/Fly-image.md

@Jackenmen Jackenmen added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 26, 2023
@tjex
Copy link
Contributor

tjex commented Apr 18, 2023

Let me know if I'm missing something, but it is stated in the first step of persisting data that you need to execute the commands in the same folder that has fly.toml in it.

Or are you specifically meaning at step 5 under 'deploying' that it should state there that you should be in the folder from where the fly.toml was created in step 3?

@Jackenmen
Copy link
Contributor Author

Or are you specifically meaning at step 5 under 'deploying' that it should state there that you should be in the folder from where the fly.toml was created in step 3?

That's what I mean, yes. The mention of it in the "Persisting server data" section should stay but it should also be noted in the "Deploying" section since it is an earlier step and until that point, nothing in the documented tells you that you should run the command from the directory of the created fly.toml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants