Skip to content
This repository has been archived by the owner on Jul 15, 2021. It is now read-only.

nested comments #10

Closed
AurelDragut opened this issue Feb 27, 2017 · 7 comments
Closed

nested comments #10

AurelDragut opened this issue Feb 27, 2017 · 7 comments
Assignees

Comments

@AurelDragut
Copy link

Hey, i have made comments also commentable to get nested comments.

i made comments commentable and i got them nested but i don't quite see a proper way to count the children of the comments on the number of the main model's comments...

i would do a

foreach ($model->comments as $comment) {
         $totalcomments += $comment->comments->count(); 
}

but i get an error about some trait, i guess there is a conflict between commentable and cancomment

@AurelDragut
Copy link
Author

Any news on this issue, mate?

@actuallymab
Copy link
Owner

Hi @AurelDragut. First, thank you for your support & ping on this. I was unable to think this package as you mentioned, I will upgrade this package's version to 1.0.0 in a few days with this update.

@AurelDragut
Copy link
Author

Maybe i didnt explain well enough. Anyway this can get alot better and as soon as i get how to do it i will be happy to help on it. I am also thinking about a notification system: any user that comments on a model object can get notified of any new comment that is added to that model object (either that is a model object or a comment added to that model object).

@actuallymab
Copy link
Owner

actuallymab commented Apr 5, 2017

@AurelDragut
Copy link
Author

Sorry, mate, i have no experience with tests. i don't know how to do tests yet.

@actuallymab
Copy link
Owner

You might seem that as an example.

@actuallymab
Copy link
Owner

If anything wrong or misunderstand, you can reopen issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants