You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Allowing Box(42) is different from allowing Box(#{}) in the case where typeof #{} === 'object'.
Also I think the message makes strong assumptions:
If primitives can be stored in a Box, then code checking if a Record/Tuple transitively contains an object can no longer be performed with a containsBoxes predicate. Instead the code will need to also check the contents of the boxes.
We could imagine a different predicate, aka Box.hasBoxWithIdentity or Object.containsObject (with identity bearing object being implied). Similarly I would precise that the alternative would be to recursively check the content of boxes.
The text was updated successfully, but these errors were encountered:
Thanks for raising this @mhofman - the more issues that are raised to ensure the right details are captured in the right tone the more valuable I think this tool will be.
I've raised a PR that attempts to address this issue.
Allowing
Box(42)
is different from allowingBox(#{})
in the case wheretypeof #{} === 'object'
.Also I think the message makes strong assumptions:
We could imagine a different predicate, aka
Box.hasBoxWithIdentity
orObject.containsObject
(with identity bearing object being implied). Similarly I would precise that the alternative would be to recursively check the content of boxes.The text was updated successfully, but these errors were encountered: