Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-torch-sparse] not build successfully #227

Closed
nihil39 opened this issue Mar 7, 2023 · 8 comments
Closed

[python-torch-sparse] not build successfully #227

nihil39 opened this issue Mar 7, 2023 · 8 comments

Comments

@nihil39
Copy link

nihil39 commented Mar 7, 2023

Hi, I get this error while building python torch sparse 0.6.16-1

In file included from csrc/cpu/diag_cpu.cpp:3:
csrc/cpu/utils.h:4:10: fatal error: parallel_hashmap/phmap.h: No such file or directory
    4 | #include "parallel_hashmap/phmap.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
error: command '/usr/bin/gcc' failed with exit code 1

ERROR Backend subprocess exited when trying to invoke build_wheel
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: python-torch-sparse

I'm trying to build this package as a dependency of pytorch geometric, a previous version of this package, now unmaintained can be found here

Thank you.

@nihil39
Copy link
Author

nihil39 commented Mar 7, 2023

I think some dependencies should be added in the PKGBUILD, at least
python gcc cuda cmake python-scipy python-setuptools python-pytest python-pytest-cov python-pytorch python-pytorch_scatter

@nihil39
Copy link
Author

nihil39 commented Mar 7, 2023

The error I got depends on the lack of this package: parallel-hashmap. Thanks to Lone Wolf of the Arch Linux forum, see this post

Please add parallel hashmap (and Pytorch?) as dependencies.

@acxz
Copy link
Owner

acxz commented Mar 7, 2023

Nice finds.

@nihil39 do you want to give a go and writing a PR to try to resolve the issue? I can help you along the way!

@nihil39
Copy link
Author

nihil39 commented Mar 7, 2023

What is a PR?
I think we have to modify the PKGBUILD to require parallel-hashmap and Pytorch as dependencies, maybe parallel-hashmap is only required as a build time dependency and not a runtime one.

@acxz
Copy link
Owner

acxz commented Mar 7, 2023

So a PR stands for a pull request. It is how you can help me maintain and update the package.

See, by hosting my arch linux PKGBUILDs on github, not only can we comment easily like this via issues; but you can also make the fix to the PKGBUILD yourself and submit it as a change to this repo (PR). As you may know I maintain around hundreds of packages and I may not have time to give all the packages love, so my accepting PRs from the community (i.e. you) it makes my life (and everyone else that uses these packages) easier!

You can start by first forking this repository.

@nihil39
Copy link
Author

nihil39 commented Mar 11, 2023

So I should fork you repository, add the parallel-hashmap dependency to the python-torch-sparse PKGBUILD and make a pull request to you?

@acxz
Copy link
Owner

acxz commented Mar 11, 2023

Exactly!

@acxz acxz changed the title [python-torch-sparse-0.6.16-1] not build successfully [python-torch-sparse] not build successfully Jun 22, 2023
@acxz
Copy link
Owner

acxz commented Jun 22, 2023

closed with b4ba884

@acxz acxz closed this as completed Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants