Update Simple8bCode.h #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move the old encode function and old decode function in comment, add the optimal encode function and decode function, moreover add some small functions which are described in Anh & Moffat: "Index compression using 64-bit words."
|
Right now the changes would break the build of the whole project. At the moment, two static methods for encode and decode are required. Your version requires an instance to be made with the constructor. I would very much like to keep the old interface. Can you make the change? Otherwise I will, when I have time again. Can you also please fix these two little things:
|
added 3 commits
January 12, 2016 13:49
remove the object functions to let the new Simple8bCode.h has the same structure as the old one, then we can make sure that the old tests which run for the old one are also adaptive for the new one.
Buchhold
pushed a commit
that referenced
this pull request
Jan 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move the old encode function and old decode function in comment, add the optimal encode function and decode function, moreover add some small functions which are described in Anh & Moffat: "Index compression using 64-bit words."