Check code style during Travis CI build #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floriankramer
approved these changes
Aug 17, 2018
niklas88
moved this from Approved waiting on decision/external
to Review Approved
in QLever
niklas88
moved this from Review Approved
to Approved waiting on decision/external
in QLever
|
@floriankramer maybe we could combine this with doing just a |
joka921
approved these changes
Sep 8, 2018
misc/format-check.sh
Outdated
| printf "Use clang-format with the .clang-format provided in the QLever\n" | ||
| printf "repository's root to ensure all code files are formatted " | ||
| printf "properly.\n" | ||
| printf "\x1b[m" |
There was a problem hiding this comment.
Since this was an issue as far as I remember it would be nice to tell which clang-format version must be used. (at least "must match the ones from the ubuntu18.04 repo" although explicit x.y.z would of course be nicer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit just adds the check without formatting so it breaks the build as intended