Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change OrderBy asString() to match, JOIN etc #109

Merged
merged 2 commits into from Aug 24, 2018
Merged

Change OrderBy asString() to match, JOIN etc #109

merged 2 commits into from Aug 24, 2018

Conversation

niklas88
Copy link
Member

It's more consistent and thus also easier to read

@niklas88 niklas88 requested a review from joka921 August 21, 2018 14:16
@niklas88
Copy link
Member Author

Argh, forgot the tests relied on matching Operation::asString()

joka921
joka921 approved these changes Aug 23, 2018
View reviewed changes
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is consistent with the other output, LGTM

@niklas88 niklas88 merged commit 4aceec2 into ad-freiburg:master Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joka921 joka921 joka921 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niklas88 @joka921