Enable End-to-End test during docker build #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables testing using our e2e/e2e.sh script during `docker build`. The tests are executed in the final runtime stage of the multi stage Dockerfile which makes sure that we are testing the final configuration. This also leaves the queryit.py tool as well as the example queries in /app/e2e_data in the final container. While these are not strictly needed they offer useful examples. In a later step we may replace the Travis CI build with just building the docker container there as well. This would get rid of the version hacks
|
Ok I think doing it like this on every |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables testing using our e2e/e2e.sh script during
docker build.The tests are executed in the final runtime stage of the multi stage
Dockerfile which makes sure that we are testing the final configuration.
This also makes sure that images build automatically in the docker
cloud are tested.
This also leaves the queryit.py tool as well as the example queries in
/app/e2e_data in the final container. While these are not strictly
needed they offer useful examples.
In a later step we may replace the Travis CI build with just building
the docker container there as well. This would get rid of the version
hacks