Small changes #13
Merged
Small changes #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Query strings may use '+' to escape spaces and this may also be generated by some URL libraries (e.g. http://golang.org/pkg/net/url). These are already supported in the QLever API but were incorrectly decoded in the test UI. This allows pasting such querys into the UI for further experimentation.
Instead of a HashMap just use an appropriately sized array on the stack, this should be quite a bit faster (alloc on stack is often just a pointer bump). Also 256 bytes leaves plenty of room on a default size stack. Also add a join function similiar to Python's string.join(). I got a bit crazy here and it's in fact a template that works with anything supporting operator+= We may want to use template functions in the futue to get rid of variants with different types too. This also synchronizes with my ad::util variant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are my changes to StringUtils and the JavaScript. I'm not super sure whether the templated join function is a bit too funky, however at least it does have a Test 馃帀
Doing a quick search it looks like none of this is used during index construction so the performance benefits are likely tiny but oh well...
Also there is some reformatting for Google Style Guide in StringUtils.h