Added support for HAVING. Fixes #104. #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added utiliztion of having for CountAvailablePredicates by automatically replacing filters on a ql:has-predicate triple with HAVING statements if the pattern trick is used.
niklas88
reviewed
Sep 23, 2018
| ?x ql:has-predicate ?predicate . | ||
| } | ||
| GROUP BY ?predicate | ||
| HAVING (?predicate < <Z) (?predicate = <Religion>) |
There was a problem hiding this comment.
So these are multiple HAVING clauses which are treated as AND right? I think we should document that somewhere besides the SPARQL standard. Also I think we should have a few more examples in the e2e Tests, especially also the very basic usage. I like using them as normal examples and to look up how some syntax works and thus having a few different cases is both a useful test and an example.
There was a problem hiding this comment.
I added another e2e test and expanded the GROUP BY paragraph in the readme.
| @@ -1510,6 +1486,61 @@ void QueryPlanner::applyFiltersIfPossible( | |||
| } | |||
| } | |||
|
|
|||
| // _____________________________________________________________________________ | |||
| std::shared_ptr<Operation> QueryPlanner::createFilterOperation( | |||
There was a problem hiding this comment.
this is much nicer as its own method, thanks!
| } | ||
| } | ||
|
|
||
| // _____________________________________________________________________________ | ||
| void SparqlParser::addFilter(const string& str, | ||
| ParsedQuery::GraphPattern* pattern) { | ||
| vector<SparqlFilter>* _filters) { |
There was a problem hiding this comment.
I think this is actually quite a bit clearer than the old version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added utiliztion of having for CountAvailablePredicates by
automatically replacing filters on a ql:has-predicate triple with
HAVING statements if the pattern trick is used.