Separate prefix file, fixing #141 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the unused getJsonForPrefixes() method * Merge initializeNewPrefixes and initializeRestartPrefixes which only differed in if they accepted too many/too few prefixes and clearing the _prefixVec * Also remove TODOs that were cleared up
The MetaDataConverter seems to break on trying to convert (i.e. detect as fine) a current index. I don't think that has anything todo with the new changes but these are untested until I figure that out.
niklas88
requested review from
floriankramer
and removed request for
joka921
There was a problem hiding this comment.
I haven't worked with the index much, so I'm not certain that I haven't missed some important impact of the change, but it mostly looks good to me.
One change I'm not sure about is, that having less than NUM_COMPRESSION_PREFIXES prefixes only throws a warning instead of thrwoing an error. As far as I can tell that should not be an issue, as the value only seems to be important when decompressing strings, where a std::array instead of a vector is used for prefix lookup, preventing access of uninitialized memory, but I'm not quite certain.
floriankramer
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently has two major commits.
.prefixesfile leaving only a boolean flag in the configuration file.Sadly the
MetaDataConverterseems to break on current indices instead of recognizing them as fine. I don't think that has anything to do with my new changes though. Until I figure that out it remains untested. Still I wanted to get this PR here so we don't get a duplication of work.