Added optimized handling of range filters on sorted data. #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@floriankramer any idea why the this seems to crash in the End-to-End Tests? |
|
@floriankramer while you're changing ResultTable.h please fix #148 |
niklas88
reviewed
Nov 13, 2018
| } else { | ||
| getEngine().filter(*static_cast<vector<RT>*>(subRes->_fixedSizeData), | ||
| [lhs, rhs](const RT& e) { | ||
| return ValueReader<T>::get(e[lhs]) < |
There was a problem hiding this comment.
Why do we need ValueReader here but not with the two cases above?
There was a problem hiding this comment.
Currently the value reader is only used for non equality comparisons, as the assumption is, that two element are equal if their bytes are equal (the last four bytes of a float value are always zero).
src/engine/Filter.cpp
Outdated
| data->begin(), data->end(), rhs_array, | ||
| [lhs](const RT& l, const RT& r) { return l[lhs] < r[lhs]; }); | ||
| if (lower != data->end()) { | ||
| // rhs appears within the data, take all elements before and after |
There was a problem hiding this comment.
I think we take the ones in the range not before and after
niklas88
reviewed
Nov 14, 2018
| @@ -400,8 +416,9 @@ vector<RT>* Filter::computeFilterFixedValueForResultType( | |||
| data->begin(), data->end(), rhs_array, | |||
| [lhs](const RT& l, const RT& r) { return l[lhs] < r[lhs]; }); | |||
There was a problem hiding this comment.
The prefix filter is currently only run on KB type columns, which can be interpreted directly.
niklas88
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds special cases for range filters on sorted data to the computation of filer results. Instead of iterating over the entire input data and applying a comparator for each element, the upper and lower bound of the target range are found using
std::lower_boundandstd::upper_boundand the range is then copied to the result vector.