Added a duplicate alias check to the parser. Fixes #153. #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for #153.
Due to split parsing of aliases in both the parser and the GroupBy operation queries with theoretically equal aliases, that differ in their spelling (e.g.
(COUNT(?object) as ?count)and(COUNT(?object) AS ?count)) will be rejected. Due to that the query from the issue is only fixed in so far as it results in an error message instead of a crash.Better detection of alias equality would require parsing aliases more fully during the parsing stage. I can create a pr for that, but it might be worth waiting until the planned sparql parser replacement, especially as this only concerns a small subset of queries.