Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for CountAvailablePredicates that prevents out of range access of the input. #169

Merged
merged 1 commit into from Dec 20, 2018

Conversation

floriankramer
Copy link
Member

@floriankramer floriankramer commented Dec 20, 2018

The check for duplicate subjects in the CountAvailablePredicates operation accessed the vector before it checked if the index into the vector was valid.

@niklas88
Copy link
Member

💃 no need to test fixes if you know you're right, right… Joke aside I just tested it and this fixes the query I mentioned on the mailinglist and also the full one used in my script.

Copy link
Member

@niklas88 niklas88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested to fix a crashing query

@niklas88 niklas88 merged commit 7e2821a into ad-freiburg:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants