Added missing debug output to a variety of operations. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Independent from adding this set of debug information which I think is definitely a good idea, I
|
niklas88
approved these changes
Jan 22, 2019
| @@ -108,6 +108,8 @@ size_t CountAvailablePredicates::getCostEstimate() { | |||
|
|
|||
| // _____________________________________________________________________________ | |||
| void CountAvailablePredicates::computeResult(ResultTable* result) const { | |||
| LOG(DEBUG) << "Beginning with computing the CountAvailablePredicates result." | |||
There was a problem hiding this comment.
"Begin computing …" sounds a bit weird to me. I think what that's because "-ing" words are normally for stuff that that takes time and it clashes with "the beginning". Also in "Finished with computing the " one can drop the "with". Both of these are used a bunch of times.
There was a problem hiding this comment.
I've changed the messages to have the same structure as the messages of older operations (e.g. OrderBy)
… the style of the old messages.
floriankramer
force-pushed
the
missing_debug_output
branch
from
acb026a
to
a0cf106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds debug logging to the beginning and end of all operations written by me (which where so far mostly lacking in any output in the logs.