Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns exclude lang predicates #186

Closed
wants to merge 3 commits into from
Closed

Patterns exclude lang predicates #186

wants to merge 3 commits into from

Conversation

niklas88
Copy link
Member

@floriankramer this is my (untested since scientists has no literals) version of ignoring the @lang@<predicate> predicates. It also includes some small clean ups, so maybe we can figure out what to take from which version.

@floriankramer
Copy link
Member

I'd try merging your version into mine. That way I could include your cleanups and the functional way of finding the upper and lower bound of the @..@ prefixes while avoiding having to do a rebase for the CreatePatternsMain executable which creates patterns for an existing index, that I just wrote and added to my pr.

@niklas88
Copy link
Member Author

@floriankramer I think there will be too many conflicts for direct merging, even with git cherry-pick <hash> but I'm not sure. I'm currently trying to test this on wikidata-small. As the new TODO indicates I'm not totally happy with my current version anyway.

@niklas88
Copy link
Member Author

niklas88 commented Jan 29, 2019

@floriankramer ok I think my version doesn't really work on wikidata-small, for

PREFIX wd: <http://www.wikidata.org/entity/>
PREFIX wdt: <http://www.wikidata.org/prop/direct/>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX wikibase: <http://wikiba.se/ontology#>
    
SELECT ?pred (COUNT(?pred) AS ?count) WHERE {
  ?human wdt:P31 wd:Q5 .
  ?human ?pred ?obj .
}
ORDER BY DESC(?count)
GROUP BY ?pred

I get results but not for the ql:has-predicate variant.

@niklas88
Copy link
Member Author

This has been merged with Florian's PR for the same idea getting the best of both

@niklas88 niklas88 closed this Jan 29, 2019
@niklas88 niklas88 deleted the patterns_exclude_lang_predicates branch July 19, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants