Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Pattern Trick Stats #188

Merged
merged 2 commits into from Feb 5, 2019
Merged

Improve Pattern Trick Stats #188

merged 2 commits into from Feb 5, 2019

Conversation

niklas88
Copy link
Member

This builds on the #187 PR so that should be merged first.

This changes the computation of the stats to (I think) match @hannahbast's idea. The total number of predicates has to be with repetitions i.e. what a non pattern trick version would use as subresult.

Copy link
Member

@floriankramer floriankramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niklas88 niklas88 merged commit 765c9e2 into ad-freiburg:master Feb 5, 2019
@niklas88 niklas88 deleted the fix_pattern_trick_stats branch July 19, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants