Finish result in Operation::getResult() and add size to performance digest #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing result->finish() in Operation::getResult() makes sure no other thread accesses an unfinished RuntimeInformation. Also it is easier to maintain and resembles the use of result->abort() We also add the result size (rows and columns) to the performance digest.
We already import it so we may as well use it here too. Also we can now have non string values in details and with some trickery they even print with thousandth separators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing
result->finish()inOperation::getResult()makes sure that no otherthread accesses an unfinished
RuntimeInformation. Also it is easier tomaintain and resembles the use of
result->abort()We also add the result size (rows and columns) to the performance
digest.