Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FILTER (lang(?label) = "en") and fix langMatches() #194

Closed
niklas88 opened this issue Feb 26, 2019 · 3 comments
Closed

Support FILTER (lang(?label) = "en") and fix langMatches() #194

niklas88 opened this issue Feb 26, 2019 · 3 comments
Assignees

Comments

@niklas88
Copy link
Member

We should support the standard

FILTER (lang(?label) = "en")

Instead of only

FILTER langMatches(lang(?label), "en")

which is also slightly wrong as it should match also "en-ca", "en-us" and so on.

@floriankramer
Copy link
Member

@niklas88 Do we need support for langMatches? implementing FILTER (lang(?label) = "en") is trivial.
langMatches would probably need additional index structures, as we would need to be able to match language ranges, and collections of language ranges. A language range is any prefix of a language tag, where the range contains the tag only if the range is a prefix of the tag, and the character after the prefix is "-" (according to RFC3066 paragraph 2.5)

@niklas88
Copy link
Member Author

niklas88 commented Apr 2, 2019 via email

@niklas88
Copy link
Member Author

fixed in #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants