Fix for the ASSERTION bug that Niklas discovered. #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklas88
approved these changes
Mar 15, 2019
src/index/MetaDataTypes.cpp
Outdated
| // will have an empty result since the first | ||
| // entry is already too big. In this case our result will | ||
| // be empty and we can perform a short cut. | ||
| if (it != _blocks.begin()) { |
There was a problem hiding this comment.
I think the comments are great but we can still make the code a bit more understandable by turning this into a positive condition:
if (it == _blocks.begin()) {
// always empty result…
return {it->_startOffset, 0};
}
it--;
also we could use the {} syntax for the other return as well
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be commented, check out if this fixes your issue.