Fix assertion failure in getFollowBlockForLhs() (#206) #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for tackling the assertion failure in #206. Turns out fixing this function looks a bit harder as it's not clear what to return so the rest doesn't crash. Currently the offending query triggers the AD_CHECK(false) so we still need to figure out what to do about it
|
Checkout #211 which would be my suggestion. |
|
@joka921 oh great, thanks for your work didn't have the patience yesterday to figure out what to do outside the function yesterday. Can't we combine this change with your changes to |
|
@joka921 nevermind I missed the case where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently WiP, the first commit is in preparation for tackling the assertion failure in #206.
Turns out fixing this function looks a bit harder as it's not clear what
to return so the rest doesn't crash. Currently the offending query
triggers the AD_CHECK(false) so we still need to figure out what to do
about it