Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OPTIONAL{} #22

Closed
niklas88 opened this issue Jul 28, 2017 · 1 comment
Closed

Support OPTIONAL{} #22

niklas88 opened this issue Jul 28, 2017 · 1 comment

Comments

@niklas88
Copy link
Member

This is used by Aqqu for name relations (fb:type.object.name) so it also gets entities without a name such as dates.

As an example with QLever I currently make the optional name mandatory and get the following query

PREFIX fb: <http://rdf.freebase.com/ns/>
SELECT DISTINCT ?0 ?0name WHERE {
   fb:m.02y1vz fb:internet.website.launched ?0 .
   ?0 fb:type.object.name ?0name . 
   FILTER (?0 != fb:m.02y1vz) 
} LIMIT 300

This doesn't find an answer while what Aqqu really wanted to generate is

PREFIX fb: <http://rdf.freebase.com/ns/>
SELECT DISTINCT ?0 ?0name WHERE {
   fb:m.02y1vz fb:internet.website.launched ?0 .
   OPTIONAL {?0 fb:type.object.name ?0name . }
   FILTER (?0 != fb:m.02y1vz) 
} LIMIT 300

which gives the correct answer. The alternative would be to do this as two separate queries but this would need more special treatment for the QLever backend.

Currently this contributes to a much worse avg-F1 (36% vs 65%) with QLever even when using the exact same model (actually trained using QLever)

@Buchhold Buchhold self-assigned this Jul 28, 2017
@Buchhold Buchhold removed their assignment Dec 6, 2017
@Buchhold
Copy link
Member

Buchhold commented Dec 6, 2017

I still agree that this is an important feature. However, I fear I won't really have time. I really want to get the memory savvy version done before everything else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants