Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter doesn't really filter #23

Closed
niklas88 opened this issue Aug 18, 2017 · 7 comments
Closed

Filter doesn't really filter #23

niklas88 opened this issue Aug 18, 2017 · 7 comments
Assignees
Labels

Comments

@niklas88
Copy link
Member

In the following query the last entity filtered out is acutally in the resultset. Checking for '==' to only get this entity doesn't work either. The first two on the other hand seem to get filtered out but switching the last two doesn't really filter now-second.

PREFIX fb: <http://rdf.freebase.com/ns/>

SELECT DISTINCT ?1 ?o ?o2 WHERE {
 fb:m.0fkvn fb:government.government_office_category.officeholders ?0 .
 ?0 fb:government.government_position_held.jurisdiction_of_office fb:m.0vmt .
 ?0 fb:government.government_position_held.office_holder ?1 .
 FILTER (?1 != fb:m.0fkvn && ?1 != fb:m.0vmt && ?1 != fb:m.018mts) 
} LIMIT 300
@Buchhold
Copy link
Member

Combinations using && are not implemented, yet. There should really be an error message, though. Workaround: Use multiple Filter clauses

@niklas88
Copy link
Member Author

Ok I tried but this crashes QLever:

PREFIX fb: <http://rdf.freebase.com/ns/>

SELECT DISTINCT ?1 ?o ?o2 WHERE {
 fb:m.0fkvn fb:government.government_office_category.officeholders ?0 .
 ?0 fb:government.government_position_held.jurisdiction_of_office fb:m.0vmt .
 ?0 fb:government.government_position_held.office_holder ?1 .
 FILTER (?1 != fb:m.0fkvn)
 FILTER (?1 != fb:m.0vmt)
 FILTER (?1 != fb:m.018mts) 
} LIMIT 300

@Buchhold
Copy link
Member

crashes? or an error? FILTERS currently need dots like other triples. Looked it up and this should be changed

@Buchhold Buchhold added the bug label Aug 18, 2017
@niklas88
Copy link
Member Author

niklas88 commented Aug 18, 2017

Crash as in hard segfault, I tried with dots as well because I was unsure, both segfault

@Buchhold
Copy link
Member

yeah, i will need to have a look. many filters used to work without problems, maybe this as something to do with the recent improvements for speed in aqqu that were concerning filters. will have a look asap

@Buchhold Buchhold self-assigned this Aug 18, 2017
@niklas88
Copy link
Member Author

That sounds like a great place to first create a test and then make it not fail

@Buchhold
Copy link
Member

Fixed in this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants