Fix getVariableColumns() for TwoColumnJoin fixes #256 #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwoColumnJoin currently only implements a special case. The more general case is prevented from use by a high cost (this is the current state of affairs not introduced by this PR). However for that special case the column mapping was bogus. The old code assumed that the columns are both sides concatenated with the join columns removed from the right side. So the same as for normal Join. However with the special case one side is only join columns and we take the column mapping always from the other side.
Closed
niklas88
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TwoColumnJoin currently only implements a special case. The more general
case is prevented from use by a high cost (this is the current state of
affairs not introduced by this PR).
However for that special case the column mapping was bogus. The old code
assumed that the columns are both sides concatenated with the join
columns removed from the right side. So the same as for normal Join.
However with the special case one side is only join columns and we take
the column mapping always from the other side.
This is still a bit more ugly than I'd like but it's a clear improvement over the
current state, also the way the non-implemented case was avoided with a large cost
is at least better documented now.