Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #25 #26

Merged
merged 1 commit into from Dec 6, 2017
Merged

Fix #25 #26

merged 1 commit into from Dec 6, 2017

Conversation

niklas88
Copy link
Member

@niklas88 niklas88 commented Dec 4, 2017

Testing out my hypothesis that scanNonFunctionalRelation's special case for scanning the follow block should not read that from the psoFile it seems to fix the crash and return a correct result. Sadly I'm not sure how to trigger this in a small test query so I don't have a nice regression test.

My original argument was:

It seems to me that _psoFile is a WidthTwoList so pairs of Ids but we're trying to read a pair<Id, off_t> which is what indexFile consists of? Also the comments say we want to read a follow block but blocks are read from the indexFile

@Buchhold Buchhold merged commit f2ce285 into ad-freiburg:master Dec 6, 2017
@niklas88 niklas88 deleted the fix_crash branch March 3, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants