Don't crash on empty index. Fixes #262 #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is already several warnings but since we continue trying all steps even on an empty index we really shouldn't crash. We can still think about just refusing to process empty input but then again it's always nice when things "work" even in special cases. No matter what we do crashing isn't right
lehmann-4178656ch
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
LGTM, tested and works nicely. Found #266 during tests but that's a different issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already several warnings but since we continue trying all steps
even on an empty index we really shouldn't crash.
We can still think about just refusing to process empty input but then
again it's always nice when things "work" even in special cases.
No matter what we do crashing isn't right