Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement VALUES syntax and operation #270

Merged
merged 4 commits into from Jul 19, 2019
Merged

Implement VALUES syntax and operation #270

merged 4 commits into from Jul 19, 2019

Conversation

niklas88
Copy link
Member

This is the original VALUES implementation extracted from #258.

Note: This needs the fix to the galloping join from #269 to function as it easily triggers the broken case for example when using a single value as in the following example query (which only gave one result instead of >7000):

PREFIX wd: <http://www.wikidata.org/entity/>
PREFIX wdt: <http://www.wikidata.org/prop/direct/>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX schema: <http://schema.org/>
PREFIX wikibase: <http://wikiba.se/ontology#>
SELECT ?city ?cityLabel ?citytype WHERE {
  VALUES ?citytype { wd:Q515}
  ?city wdt:P31 ?citytype .
  ?city rdfs:label ?cityLabel .
  FILTER (lang(?cityLabel) = "en") .
}

@niklas88 niklas88 removed the request for review from floriankramer July 19, 2019 14:48
@niklas88
Copy link
Member Author

Tested and reviewed this LGTM

@niklas88 niklas88 merged commit 1466a03 into ad-freiburg:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants