Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing assignment/uninitialized value #292

Merged
merged 1 commit into from Nov 12, 2019
Merged

Fix missing assignment/uninitialized value #292

merged 1 commit into from Nov 12, 2019

Conversation

niklas88
Copy link
Member

The test checked for _langPredLower/UpperBound being zero but did never
correctly set them. Thus the stack value for res was indeed
uninitalized. Only found this because valgrind seems to be better on
s390x.

The test checked for _langPredLower/UpperBound being zero but did never
correctly set them. Thus the stack value for res was indeed
uninitalized. Only found this because valgrind seems to be better on
s390x.
@niklas88
Copy link
Member Author

Also I've seen this leading to an actual test failure on s390x and verified that this change fixes that as well.

Copy link
Member

@lehmann-4178656ch lehmann-4178656ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but out of curiosity, why are the

{
 VocabularyMerger m;
 [res = ]m.mergeVocabulary(...);
}

always in a different scope then the rest of the test? I don't see that they are performed multiple times in the same test - or am I missing something obvious?

@niklas88
Copy link
Member Author

LGTM, but out of curiosity, why are the

{
 VocabularyMerger m;
 [res = ]m.mergeVocabulary(...);
}

always in a different scope then the rest of the test? I don't see that they are performed multiple times in the same test - or am I missing something obvious?

No idea, I guess that's to test that anything freed by the merger doesn't break access.

@niklas88 niklas88 merged commit f38e772 into ad-freiburg:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants