Fixing Escaped Strings in the Sparql Parser #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…class and started testing it.
TODO: The method is not the most efficient, so we can as well make it safe.
TODO: test that illegal inputs always throw and never segfault.
…for the regex engine.
joka921
commented
Jan 3, 2020
| const std::string SparqlLexer::WS = "(\\x20|\\x09|\\x0D|\\x0A)"; | ||
| const std::string SparqlLexer::ECHAR = "\\\\[tbnrf\"']"; | ||
| const std::string SparqlLexer::WS = R"((\x20|\x09|\x0D|\x0A))"; | ||
| const std::string SparqlLexer::ECHAR = R"(\\[tbnrf\\"'])"; |
There was a problem hiding this comment.
The first of those lines is just a reformatting.
In the second line their were two backslashes missing.
niklas88
approved these changes
Jan 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Regex Filters that contained Escape Sequences were neither handled correct
by the Lexer nor by the Parser (see #296). This PR fixes these bugs.
It implements a function to unify the different ways to specify Strings in Sparql/Turtle (" with escapes versus """ without escapes) to a form, that performs unescaping of
\t \n \\\"...Currently, the handling of strings that contain escaped characters is also wrong in the turtle Parser.
However to fix this, we require some more changes since the serialization of the vocabulary has to be changed as soon as the vocabulary elements may contain
\ncharacters. So I would recommend first merging this and then using it as a base for the other fix.