Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken TSV export #308

Merged
merged 1 commit into from Jan 16, 2020
Merged

Fix broken TSV export #308

merged 1 commit into from Jan 16, 2020

Conversation

hannahbast
Copy link
Member

Fix broken TSV export

  1. Fixes a classical bug (string response -> response, so that response from the surrounding context is set instead of a local variable that is never used)

  2. Corrects media type of the HTTP response: was text/tsv, should be text/tab-separated-values

1. Fixes a classical bug (string response -> response, so that response
from the surrounding context is set instead of a local variable that is
never used)

2. Corrects media type of the HTTP response: was text/tsv, should be
text/tab-separated-values
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for finding this! LGTM

@joka921 joka921 merged commit 5e70bed into master Jan 16, 2020
@hannahbast hannahbast deleted the fix-tsv-export-2 branch January 16, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants