Strange Rebase Test #321
Closed
Strange Rebase Test #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- now we have completely removed the dependency from google::sparsehash and migrated to absl.
-- Note that so far, no unescaping is performed.
- Transitive Paths use HashSets which now also have undefined orderings with absl. Tests don't rely on this anymore - The case, where a prefix was used with an empty "content" (e.g. <a> wd: <b>) was broken before, luckily there was a unit test and this is now fixed.
…TL file. - Previously there was a "parsing of ttl has failed, but there is still content left" warning, although the remainder of the ttl input was only whitespace. - This was due to a bug in the Parser's skipWhitespace() function which failed if the input consisted of ONLY whitespace. This is now fixed.
…ashSet # Conflicts: # src/parser/TurtleParser.cpp # src/parser/TurtleParser.h
- also apply the normalization of literals correctly during index build time - Adapt the Index unit tests to "legal" knowledge bases - Disable the CTRE parser for now, since it becomes awefully slow with the PnameNS and PnLocal changes for some reasons. - TODO: Maybe we want to renable the CTRE Parser with the old "wrong" behavior as a very fast way to parse Wikidata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPARQL also allows escape sequences in PrefixedNames like rdfs:l,abel
These were previously unsupported, which is now fixed.
We now also transform escape sequences in sparql literals to their
correct form during index build.
Several changes to the Index class unit tests had to be made, because
they used knowledge base elements like a instead of which is no
longer supported by any of the parsers.
Disable the CTRE parser for now, since it becomes awefully slow with the
the fixes for the prefixed names. TODO: Maybe we want to reimplement the
old and wrong behavior and make CTRE a general "WikidataUnsafe" parser.
Get rid of misleading warning in case of whitespace at the end of a TTL
file. Previously there was a "parsing of ttl has failed, but there is still content left" warning, although
the remainder of the ttl input was only whitespace.
Made the ad_utility::hash_set also use absl.
now we have completely removed the dependency from google::sparsehash and
migrated to absl.