Fix block boundary bug introduced by Unicode refactoring #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After 45a68f6, the block boundary computation was no longer correct: there was always one block per word. I stumbled upon this when a freshly build index with text no longer supported the * in the argument of ql:contains-word It seems to me that there was simply one line missing, please double-check TODO: add a unit text that checks that the block boundaries are not the trivial boundaries (one block per word)
joka921
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 45a68f6, the block boundary computation was no longer correct: there was always one block per word. I stumbled upon this when a freshly build index with text no longer supported the * in the argument of ql:contains-word
It seems to me that there was simply one line missing, please double-check
TODO: add a unit text that checks that the block boundaries are not the trivial boundaries (one block per word)