More generic Cache key for Group by #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklas88
approved these changes
May 11, 2020
|
LGTM after fixing syntax issue |
graue70
reviewed
May 19, 2020
src/parser/ParsedQuery.h
Outdated
| case AggregateType::AVG: | ||
| return "AVG"; | ||
| default: | ||
| AD_THROW(ad_semsearch::Exception::CHECK_FAILED, "Illegal/unimplemented enum value in AggregateTyppeAsString. Should never happen, please report this"); |
There was a problem hiding this comment.
Typo: 'Type' instead of 'Typpe'
- correctly reflects the calculated aggregates and - uses column indices instead of variable names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache key for group by previously used the variable names instead of the column indices.
This triggered cache misses when the same query was reused with renamed variables.
This PR fixes this issue.